Skip to content

fix issue #428: use relative path instead of ${project.build.outputDirectory}/META-INF #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2020
Merged

fix issue #428: use relative path instead of ${project.build.outputDirectory}/META-INF #430

merged 1 commit into from
Jan 17, 2020

Conversation

@syjer
Copy link
Contributor

@syjer syjer commented Jan 15, 2020 •
edited
Loading

This fix issue #428 . I've checked the resulting jars and they are now correctly built (the final jar, the source jar the javadoc jars).

ATM I can't find any downside/issues.

@danfickle
Copy link
Owner

danfickle commented Jan 17, 2020

Thanks mate. Merging now.

@danfickle danfickle merged commit 98fca08 into danfickle:open-dev-v1 Jan 17, 2020
@danfickle danfickle mentioned this pull request Feb 25, 2020
Open
@vstoykov vstoykov mentioned this pull request Mar 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@syjer @danfickle